-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix incorrect download bundle #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it future-proof, it could be worth making the check more robust ensuring that the whole package name reflects the required "ansible-automation-platform-setup-bundle" or "ansible-automation-platform-setup" pattern.
By doing this you can safely assume that you are always picking the 'supported' installer bundle.
Thank you for the review. Updated the logic to check |
Could also please remove or increase the elements on the list slice for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not positive the addition is required with the other change but I guess it doesn't hurt either.
What does this PR do?
Incorrect setup bundle is downloaded with 2.4 and RHEL9 version
ansible-automation-platform-containerized-setup
How should this be tested?
Detailed bug report is provided here #199
Is there a relevant Issue open for this?
Provide a link to any open issues that describe the problem you are solving.
resolves #199
Other Relevant info, PRs, etc
Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)