Skip to content

Commit

Permalink
intentionally fail test to verify
Browse files Browse the repository at this point in the history
  • Loading branch information
Siddharth Manoj committed Nov 30, 2023
1 parent f139232 commit 624d359
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions baseplate/sidecars/live_data_watcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ def _load_from_s3(data: bytes) -> bytes:
"SSECustomerKey": loader_config["sse_key"],
"SSECustomerAlgorithm": "AES256",
}
logger.error(file_key)
except KeyError as e:
# We require all of these keys to properly read from S3.
logger.exception(
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/sidecars/live_data_watcher_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def test_s3_load_type_sharded_on_change(self):
inst = NodeWatcher(str(dest), os.getuid(), os.getgid(), 777)

new_content = b'{"live_data_watcher_load_type":"S3","bucket_name":"test_bucket","file_key":"test_file_key","sse_key":"test_decryption_key","region_name":"us-east-1", "num_file_shards": 5}'
expected_content = b'{"foo_encrypted": "bar_encrypted"}'
expected_content = b'{"foo_encrypted": "bar_encrypteds"}'

# For safe measure, run this 20 times. It should succeed every time.
# We've uploaded 5 files to S3 in setUp() and num_file_shards=5 in the ZK node so we should be fetching one of these 5 files randomly (and successfully) - and all should have the same content.
Expand Down

0 comments on commit 624d359

Please sign in to comment.