From f4203762112c8d4f92219f5095390f89003b19b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diego=20Fern=C3=A1ndez=20Barrera?= Date: Mon, 3 Apr 2017 12:17:36 +0200 Subject: [PATCH 1/2] :bug: Fix missing frees --- f2k.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/f2k.c b/f2k.c index fc03fbd..eceb5c6 100644 --- a/f2k.c +++ b/f2k.c @@ -926,6 +926,7 @@ static bool parse_kafka_broker_topic_arg(const char *const_arg, char *config = NULL; asprintf(&config, "metadata.broker.list=%s", broker); parse_kafka_config(rk_conf, NULL, config); + free(config); *ret_topic = strdup(topic); return true; @@ -2484,6 +2485,13 @@ int main(int argc, char *argv[]) { shutdown_f2k(); + if (NULL != readOnlyGlobals.kafka_discarder.rkt) { + rd_kafka_topic_destroy(readOnlyGlobals.kafka_discarder.rkt); + } + if (NULL != readOnlyGlobals.kafka_discarder.rk) { + rd_kafka_destroy(readOnlyGlobals.kafka_discarder.rk); + } + return(0); } From 9574156968c951bf47634565a679a402b82c1f58 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diego=20Fern=C3=A1ndez=20Barrera?= Date: Mon, 3 Apr 2017 12:19:39 +0200 Subject: [PATCH 2/2] :bug: Fix missing null check before free --- rb_sensor.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rb_sensor.c b/rb_sensor.c index 605359b..44f312b 100644 --- a/rb_sensor.c +++ b/rb_sensor.c @@ -1372,7 +1372,10 @@ static void rb_sensor_delete(struct sensor *sensor) { observation_id_decref(node); } - observation_id_decref(sensor->default_observation_id); + if(NULL != sensor->default_observation_id) { + observation_id_decref(sensor->default_observation_id); + } + free(sensor); }