AnnotationToAttribute doesn't work if there s an existing attribute above annotations

[bendavies]

Bug Report

Subject	Details
Rector version	0.14.2

When using DoctrineSetList::ANNOTATIONS_TO_ATTRIBUTES, entities with attributes above annotations will fail to transform the annotationa to attributes.

If the ApiResource attributes are removed, then the Doctrine annotations are correctly converted.

Minimal PHP Code Causing Issue

<?php

use ApiPlatform\Metadata\ApiResource;
use ApiPlatform\Metadata\Get;
use ApiPlatform\Metadata\GetCollection;
use Doctrine\ORM\Mapping as ORM;

#[ApiResource(
    operations: [
        new Get(),
        new GetCollection(),
    ],
    normalizationContext: ['groups' => ['policy-notice:read']],
)]
/**
 * @ORM\Entity()
 * @ORM\Table(name="policies_notices")
 */
class PolicyNotice
{}

Expected Behaviour

all the Annotations become Attributes!

[TomasVotruba]

Possibly related nikic/PHP-Parser#201

[TomasVotruba]

We'll need an isolated failing demo link from: http://getrector.org/demo, from that create failing test case pull-request.

[bendavies]

https://getrector.org/demo/a4a70f22-e7ce-4928-9e2b-b346be078bff

[TomasVotruba]

Seems like the way php-parser resolve this: nikic/PHP-Parser#887

[TomasVotruba]

We discussed it and the way is to flip those with e.g. fixer.

See nikic/PHP-Parser#887 (comment)

[bendavies]

related previous discussion
#7225

[TomasVotruba]

@bendavies That's why the PHP CS Fixer is needed to handle these situations. It can be only done with token scope.

[bendavies]

indeed, but note your last comment on that issue (granted it might be a slightly different issue)

So there is no need for such rule.

but now we think there is :)

[TomasVotruba]

It was a different scope indeed.