Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] python evaluation no longer use threshold #618

Open
loomlike opened this issue Mar 6, 2019 · 1 comment
Open

[REFACTOR] python evaluation no longer use threshold #618

loomlike opened this issue Mar 6, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request evaluation

Comments

@loomlike
Copy link
Collaborator

loomlike commented Mar 6, 2019

Description

  • Python evaluation seems no longer use threshold-based relevancy calculation. Should remove the unused argument from functions.
  • Spark evaluation still have both timestamp and threshold-based relevancy calculation.

In which platform does it happen?

  • python
  • pyspark

Other Comments

Few more clean-up:

  • merge_ranking_true_pred function no longer use col_rating
  • the function is also missing argument descriptions of the last three parameters
@loomlike loomlike added enhancement New feature or request evaluation labels Mar 6, 2019
@yueguoguo
Copy link
Collaborator

yueguoguo commented Mar 13, 2019

Python evaluation seems no longer use threshold-based relevancy calculation. Should remove the unused argument from functions.

Maybe it is rationale to still keep this as the evaluation parts in all of the notebooks in the repo follow the top k recommendation protocol. This does not mean there is no use case for other types of recommendation scenarios, i.e., recommending items that have predicted ratings larger than a pre-defined threshold.

Spark evaluation still have both timestamp and threshold-based relevancy calculation.

I can add the Python version.

Thoughts? @loomlike

merge_ranking_true_pred function no longer use col_rating

It is used by the relevancy function (if we keep it)

the function is also missing argument descriptions of the last three parameters

Will add them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request evaluation
Projects
None yet
Development

No branches or pull requests

2 participants