Skip to content

Commit 1392c5e

Browse files
committed
change junit scope to test in api-client
1 parent 92729dd commit 1392c5e

File tree

3 files changed

+4
-23
lines changed

3 files changed

+4
-23
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,22 @@
11
package com.recombee.api_client.spring.boot._2.autoconfiguration;
22

3-
import static org.junit.Assert.assertNotNull;
3+
import static org.assertj.core.api.Assertions.assertThat;
44

5-
import org.junit.Test;
6-
import org.junit.runner.RunWith;
5+
import org.junit.jupiter.api.Test;
76
import org.springframework.beans.factory.annotation.Autowired;
87
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
98
import org.springframework.boot.test.context.SpringBootTest;
109
import org.springframework.context.annotation.Configuration;
1110
import org.springframework.test.context.ActiveProfiles;
12-
import org.springframework.test.context.junit4.SpringRunner;
1311

1412
import com.recombee.api_client.RecombeeClient;
1513
import com.recombee.api_client.spring.boot._2.autoconfiguration.RecombeeClientAutoconfigurationTest.TestConfig;
1614

17-
@RunWith(SpringRunner.class)
1815
@SpringBootTest(classes = TestConfig.class)
1916
@ActiveProfiles("test")
2017
public class RecombeeClientAutoconfigurationTest {
2118

2219
@Configuration
23-
// @SpringBootApplication
2420
@EnableAutoConfiguration
2521
public static class TestConfig {
2622
}
@@ -30,6 +26,6 @@ public static class TestConfig {
3026

3127
@Test
3228
public void testAutoConfigurationExecutes() {
33-
assertNotNull(client);
29+
assertThat(client).isNotNull();
3430
}
3531
}

api-client-spring-boot-2-starter/pom.xml

-16
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,6 @@
1111
<name>Recombee API Client Spring Boot 2 Starter</name>
1212
<packaging>pom</packaging>
1313

14-
<properties>
15-
<dependency.springboot.version>${spring.boot.2.version}</dependency.springboot.version>
16-
</properties>
17-
18-
<dependencyManagement>
19-
<dependencies>
20-
<dependency>
21-
<groupId>org.springframework.boot</groupId>
22-
<artifactId>spring-boot-dependencies</artifactId>
23-
<version>${dependency.springboot.version}</version>
24-
<type>pom</type>
25-
<scope>import</scope>
26-
</dependency>
27-
</dependencies>
28-
</dependencyManagement>
29-
3014
<dependencies>
3115
<dependency>
3216
<groupId>com.recombee</groupId>

api-client/pom.xml

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
<groupId>junit</groupId>
3535
<artifactId>junit</artifactId>
3636
<version>4.13.1</version>
37+
<scope>test</scope>
3738
</dependency>
3839
<dependency>
3940
<groupId>commons-lang</groupId>

0 commit comments

Comments
 (0)