Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to prevent clear select input on blur #280

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

SerhiiTsybulskyi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, select input always clears onBlur if no coincidence with options

What is the new behavior?

Added flag to disable clearing onBlur if there is no coincidence with options to keep input value (helpful for autocomplete search)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screen.Recording.2025-02-28.at.16.29.39.mov

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit dc214e7
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/67c1d027d61d970008be698e
😎 Deploy Preview https://deploy-preview-280--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See naming feedback

@SerhiiTsybulskyi SerhiiTsybulskyi merged commit a540c86 into master Feb 28, 2025
5 checks passed
@SerhiiTsybulskyi SerhiiTsybulskyi deleted the prevent-clear branch February 28, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants