Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend pager theme to allow for styling of item counts #248

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

The pager counts were mostly just inline text without ability to be styled

What is the new behavior?

Ability to customize styling of counts as well as the full text. Also updated storybook to include these in the custom theme story

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 11:25pm

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit ff33723
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66a03bbda38ef60008a45793
😎 Deploy Preview https://deploy-preview-248--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@steppy452 steppy452 requested a review from amcdnl July 24, 2024 02:09
@amcdnl amcdnl merged commit a36da16 into master Jul 24, 2024
7 checks passed
@amcdnl amcdnl deleted the syang/pager-theme-updates branch July 24, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants