Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade sqlfluff to 3.2.x #660

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

rubytobi
Copy link
Contributor

@rubytobi rubytobi commented Nov 15, 2024

Closes #644

Since SQLFluff 3.2.0, "the bracketed arguments are now wrapped in a function_contents object". I adjusted the code base so that it works again.

@rubytobi rubytobi marked this pull request as ready for review November 15, 2024 10:57
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (a3a8ada) to head (41d1a59).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          41       41           
  Lines        2224     2229    +5     
=======================================
+ Hits         2214     2219    +5     
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reata
Copy link
Owner

reata commented Jan 31, 2025

Sorry for the delayed response, been struggling in my work for past months.

This PR makes all the sense to me. I made a few edit though:

  1. upgrade sqlfluff to 3.3.0, as this is the newest release and I see no new breaking changes.
  2. pin the sqlfluff version to 3.3.0, not using tilde equal because we rely on a lot of implementation details in sqlfluff. And based on our past experience, those can change within minor versions. To mitigate, I'll try release sqllineage on a monthly basis this year (if my workload allows for it) so that we can stay up to date with sqlfluff.
  3. split a dedicated logic for function type handling to make it a bit more readable.

Thanks for your contribution!

@reata reata merged commit b5b5e10 into reata:master Jan 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade sqlfluff dependency to 3.1.0+
2 participants