Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not fully processed top-level subquery in DML (#564) #565

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: Not fully processed top-level subquery in DML (#564) #565

merged 1 commit into from
Jan 29, 2024

Conversation

maoxingda
Copy link
Contributor

@maoxingda maoxingda commented Jan 23, 2024 •
edited by reata
Loading

fix #564

@maoxingda maoxingda force-pushed the fix/fully-process-top-level-sq-in-DML branch from 23c8340 to 9060655 Compare January 25, 2024 13:35
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c6c65e) 99.50% compared to head (9060655) 99.50%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   99.50%   99.50%   -0.01%     
==========================================
  Files          41       41              
  Lines        2208     2203       -5     
==========================================
- Hits         2197     2192       -5     
  Misses         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maoxingda maoxingda changed the title fix: issue (#564) fix: Not fully processed top-level subquery in DML (#564) Jan 26, 2024
reata
reata approved these changes Jan 29, 2024
View reviewed changes
Copy link
Owner

@reata reata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reata reata merged commit e0fbf32 into reata:master Jan 29, 2024
17 checks passed
delphisharp pushed a commit to delphisharp/sqllineage that referenced this pull request Feb 26, 2024
@maoxingda
fix: Not fully processed top-level subquery in DML (reata#565)
ffc7853
delphisharp pushed a commit to delphisharp/sqllineage that referenced this pull request Apr 15, 2024
@maoxingda
fix: Not fully processed top-level subquery in DML (reata#565)
c83237e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reata reata reata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not fully processed top-level subquery in DML
2 participants
@maoxingda @reata