Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set target table's column using metadata #557

Merged
merged 6 commits into from
May 4, 2024

Conversation

delphisharp
Copy link
Contributor

@delphisharp delphisharp commented Jan 17, 2024

The local git branch has been corrupted, so new pull

insert into targat select  a, b, c from source

old result:
source.a -> target.a
source.b -> target.b
source.c -> target.c

Get the actual column name of target table through metadata (example: a1,b1,c1):
new result:
source.a -> target.a1
source.b -> target.b1
source.c -> target.c1

Closes #528

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.54%. Comparing base (942fcf4) to head (5725d61).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          41       41           
  Lines        2193     2195    +2     
=======================================
+ Hits         2183     2185    +2     
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reata reata force-pushed the set_target_column_from_metadata branch from 8e14815 to 5725d61 Compare May 4, 2024 12:43
@reata reata merged commit 85dc1d9 into reata:master May 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set target table column name from MetaDataProvider
3 participants