Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api) Add support for the Compute4PUNCH backend #277

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

giffels
Copy link
Contributor

@giffels giffels commented Jul 1, 2024

This pull request add support for user configurable parameters in the Compute4PUNCH backend. See reanahub/reana-job-controller#430.

@giffels giffels changed the base branch from master to maint-0.9 July 1, 2024 14:05
@giffels giffels changed the title Add support for the Compute4PUNCH backend feat(api) Add support for the Compute4PUNCH backend Jul 1, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 1.25%. Comparing base (97ff214) to head (663ce7a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           maint-0.9    #277      +/-   ##
============================================
- Coverage       1.26%   1.25%   -0.01%     
============================================
  Files             10      10              
  Lines            555     558       +3     
============================================
  Hits               7       7              
- Misses           548     551       +3     
Files Coverage Δ
reana_workflow_engine_cwl/cwl_reana.py 0.00% <0.00%> (ø)

@giffels giffels force-pushed the add/c4p_user_conf_values branch from 663ce7a to 724a740 Compare July 3, 2024 13:58
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready!

mdonadoni pushed a commit to giffels/reana-workflow-engine-cwl that referenced this pull request Jul 4, 2024
@mdonadoni mdonadoni force-pushed the add/c4p_user_conf_values branch from 724a740 to 168ebca Compare July 4, 2024 13:08
@mdonadoni mdonadoni force-pushed the add/c4p_user_conf_values branch from 168ebca to 9b2a3d0 Compare July 4, 2024 15:30
@mdonadoni mdonadoni merged commit 9b2a3d0 into reanahub:maint-0.9 Jul 5, 2024
12 checks passed
tiborsimko added a commit to tiborsimko/reana-workflow-engine-cwl that referenced this pull request Dec 3, 2024
chore(maint-0.9): release 0.9.4 (reanahub#257)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#289)
build(docker): pin setuptools 70 (reanahub#287)
feat(task): allow Compute4PUNCH backend options (reanahub#277)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko added a commit to tiborsimko/reana-workflow-engine-cwl that referenced this pull request Dec 3, 2024
chore(maint-0.9): release 0.9.4 (reanahub#257)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#289)
build(docker): pin setuptools 70 (reanahub#287)
feat(task): allow Compute4PUNCH backend options (reanahub#277)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko added a commit to tiborsimko/reana-workflow-engine-cwl that referenced this pull request Jan 15, 2025
chore(maint-0.9): release 0.9.4 (reanahub#257)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#289)
build(docker): pin setuptools 70 (reanahub#287)
feat(task): allow Compute4PUNCH backend options (reanahub#277)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants