Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first langgraph commit #631

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

first langgraph commit #631

wants to merge 14 commits into from

Conversation

hfhoffman1144
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

hfhoffman1144 and others added 4 commits January 29, 2025 08:16
ruff fix
e54ab48
@martin-martin
Merge branch 'master' into langgraph
c16660d
@martin-martin
Fix dependencies, imports, and README
50baeb8 
Removed linters and formatters from pyproject.toml
Created a requirements.txt file
Updated the README file
Ran isort to fix import spacing and order
@martin-martin
Ruff rules over isort 😅
1db655f
martin-martin
martin-martin requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hfhoffman1144 , I've applied a few changes directly to your PR, they're just general-level, but LMK if you want to reverse anything.

I have one request about adding a quick usage example.

Also, there may or may not be some changes to the code here after addressing my comments in the tutorial PR.

python-langgraph/README.md Outdated

## Usage

TODO: A short note on how to run the project. You can tell them to go to the tutorial for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-martin martin-martin martin-martin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfhoffman1144 @martin-martin