Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve wrap_injection #320

Merged
merged 2 commits into from
Dec 2, 2024
Merged

improve wrap_injection #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c23011
improve wrap injection
ApostolFet Dec 2, 2024
1ba9e45
Added handler for AttributeError
ApostolFet Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/dishka/integrations/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@ def wrap_injection(
continue
dependencies[name] = dep

if not dependencies:
try:
func.__dishka_injected__ = True # type: ignore[attr-defined]
except AttributeError:
pass
else:
return func

if remove_depends:
new_annotations = {
name: hint
Expand All @@ -115,7 +123,7 @@ def wrap_injection(
]
else:
new_annotations = hints.copy()
new_params = list(func_signature.parameters.copy().values())
new_params = list(func_signature.parameters.values())

auto_injected_func: Callable[P, T | Awaitable[T]]
if additional_params:
Expand Down
Loading