Remove indexes that aren't used and that are large #11623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran some queries in prod to see what indexes weren't being used sorted by size. These are the biggest ones without many queries hitting them. Required updating django-simple-history to get the no_db_index.
|
Mostly putting this here so I don't lose it, not a huge priority, and will need a bit more testing to ship it. |
|
It would be good to make the last step here to finish and deploy this PR. |
…move-unused-indexes
|
Should be ready to review 👍 |
humitos
approved these changes
Feb 19, 2025
| @@ -171,7 +171,7 @@ class RemoteRepository(TimeStampedModel): | |||
| blank=True, | |||
| ) | |||
| # VCS provider repository id | |||
| remote_id = models.CharField(db_index=True, max_length=128) | |||
| remote_id = models.CharField(max_length=128) | |||
There was a problem hiding this comment.
Hrm, this called my attention. I think we perform a few queries based on remote_id in .com because of SSO. Have you checked this index there?
| @@ -66,13 +66,11 @@ class ExtraFieldsHistoricalModel(models.Model): | |||
| _("ID"), | |||
| blank=True, | |||
| null=True, | |||
| db_index=True, | |||
There was a problem hiding this comment.
Maybe we can use the help from @stsewd here. I don't know where these extra fields are used, and if the usage is intense.
There was a problem hiding this comment.
Don't think we use this models directly in our application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran some queries in prod to see what indexes weren't being used sorted by size.
These are the biggest ones without many queries hitting them.
Required updating django-simple-history to get the no_db_index.