Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a (simple) PDF profile #97

Merged
merged 3 commits into from
May 1, 2023
Merged

Add a (simple) PDF profile #97

merged 3 commits into from
May 1, 2023

Conversation

llemeurfr
Copy link
Contributor

Because we need to have a PDF profile released asap, Here is a simple proposal, with a text aligned with the other profiles and no introduction of a new property, as in #88.

If we agree about the addition of a start property (which means that every Readium toolkits will be ready to implement it), we'll update this profile accordingly.

Copy link
Member

@HadrienGardeur HadrienGardeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say overall, just minor tweaks.

profiles/pdf.md Outdated

## Introduction

The goal of this specification is to provide a profile of the [Readium Web Publication Manifest](https://readium.org/webpub-manifest) dedicated to pdf documents.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "PDF documents" instead of lowercase pdf.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

profiles/pdf.md Outdated
This profile relies on:

* a declaration of [conformance with this Profile](#1-declaring-conformance-with-the-pdf-profile),
* some [restrictions on the resources of the reading order](#2-restrictions-on-the-resources-of-the-reading-order),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a single restriction currently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

profiles/pdf.md Outdated

## 1. Declaring conformance with the PDF Profile

To declare that it conforms to the PDF Profile, a Readium Web Publication Manifest <strong class="rfc">must</strong> include a `conformsTo` key in its `metadata` section, with `https://readium.org/webpub-manifest/profiles/pdf` as value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be modified to say "with https://readium.org/webpub-manifest/profiles/pdf as one of its values."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

profiles/pdf.md Outdated Show resolved Hide resolved
@llemeurfr llemeurfr merged commit 1ae6f07 into master May 1, 2023
@llemeurfr llemeurfr deleted the feat/pdf-profile branch May 1, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants