Skip to content

Commit

Permalink
v1.4.2
Browse files Browse the repository at this point in the history
  • Loading branch information
danielweck committed May 25, 2020
1 parent a0f5fbe commit 7da454e
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 10 deletions.
19 changes: 18 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,28 @@
# Next

Git diff:
* https://github.com/readium/r2-navigator-js/compare/v1.4.1...develop
* https://github.com/readium/r2-navigator-js/compare/v1.4.2...develop

Changes:
* TODO

# 1.4.2

> Build environment: NodeJS `12.16.3`, NPM `6.14.5`
Changes:
* EPUB3 Media Overlays / sync-media: "caption style" view switch does not automatically trigger pause/resume.

Git revision info:
* https://unpkg.com/r2-navigator-js@1.4.2/dist/gitrev.json
* https://github.com/edrlab/r2-navigator-js-dist/blob/v1.4.2/dist/gitrev.json

Git commit history:
* https://github.com/readium/r2-navigator-js/commits/v1.4.2

Git diff:
* https://github.com/readium/r2-navigator-js/compare/v1.4.1...v1.4.2

# 1.4.1

> Build environment: NodeJS `12.16.2`, NPM `6.14.4`
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "r2-navigator-js",
"version": "1.4.1",
"version": "1.4.2",
"description": "Readium 2 'navigator' for NodeJS (TypeScript)",
"keywords": [
"readium",
Expand Down
14 changes: 7 additions & 7 deletions src/electron/renderer/media-overlays.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1402,13 +1402,13 @@ export function mediaOverlaysEscape() {
export function mediaOverlaysEnableCaptionsMode(captionsMode: boolean) {
_captionsMode = captionsMode;

if (IS_DEV) {
debug("mediaOverlaysEnableCaptionsMode() - mediaOverlaysPause() + mediaOverlaysPlay()");
}
mediaOverlaysPause();
setTimeout(() => {
mediaOverlaysPlay(_mediaOverlaysPlaybackRate);
}, 300);
// if (IS_DEV) {
// debug("mediaOverlaysEnableCaptionsMode() - mediaOverlaysPause() + mediaOverlaysPlay()");
// }
// mediaOverlaysPause();
// setTimeout(() => {
// mediaOverlaysPlay(_mediaOverlaysPlaybackRate);
// }, 300);
}

export function mediaOverlaysClickEnable(doEnable: boolean) {
Expand Down

0 comments on commit 7da454e

Please sign in to comment.