This repository has been archived by the owner on Dec 17, 2017. It is now read-only.
Storahci Initial changeset #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return | ||
| * Return true if intialization was successful | ||
| */ | ||
| BOOLEAN AhciPortInitialize( |
There was a problem hiding this comment.
In general, our coding style for function is:
RETURNTYPE
FunctionName (
_In_Sal2_Annotations PTYPE Var,
_In_Sal2_Annotations PTYPE Var
)
{
...
}
OR:
RETURNTYPE
FunctionName (_In_Sal2_Annotations PTYPE Var,
_In_Sal2_Annotations PTYPE Var)
{
...
}
Can you pick one and be consistent? Thanks!
|
@ionescu007 I made all those changes, please review latest commit. |
I am pro at making silly mistakes :/
| ) | ||
| BOOLEAN | ||
| AhciPortInitialize ( | ||
| __in PAHCI_PORT_EXTENSION portExtension |
There was a problem hiding this comment.
Use SAL 2 and just one space in all your functions, please.
There was a problem hiding this comment.
All input arguments should be CamelCase
| receivedFISPhysical = StorPortGetPhysicalAddress(adapterExtension, NULL, portExtension->ReceivedFIS, &mappedLength); | ||
| if (mappedLength == 0 || (receivedFISPhysical.LowPart % 256) != 0){ | ||
| StorPortDebugPrint(0, "\treceivedFISPhysical mappedLength:%d\n", mappedLength); | ||
| receivedFISPhysical = StorPortGetPhysicalAddress( adapterExtension, |
|
^^ sorry for that #2 :/ |
| // software should perform the appropriate error recovery actions based on whether | ||
| // non-queued commands were being issued or native command queuing commands were being issued. | ||
|
|
||
| DebugPrint("\tFata Error: %x\n", PxIS.Status); |
… detection is still not working :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.