Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoffeeScript React component generator fix #799

Merged
merged 1 commit into from
Oct 3, 2017
Merged

CoffeeScript React component generator fix #799

merged 1 commit into from
Oct 3, 2017

Conversation

ViXP
Copy link
Contributor

@ViXP ViXP commented Oct 3, 2017

Class with @ didn't work with export in footer (there is no need to set classes in global scope if they will be exported anyway, imho)

@ViXP
CoffeeScript React component generator fix (class with @ didn't work …
7d763fc 
…with export in footer, there is no need to set classes in global scope if they will be exported anyway)
@BookOfGreg
Copy link
Member

BookOfGreg commented Oct 3, 2017 •
edited
Loading

Agreed.
Just spun up my first webpack + Coffeescript project here so that I can actually start testing these things for you. Yep you're totally right, no @ needed.
Later on I'll write a test for this in this project but thanks.

Edit: I'll clean up the test failure in a moment.

@BookOfGreg BookOfGreg merged commit 8cf38f3 into reactjs:master Oct 3, 2017
@BookOfGreg BookOfGreg mentioned this pull request Oct 3, 2017
Merged
@BookOfGreg
Copy link
Member

Added a coffee wiki entry.
https://github.com/reactjs/react-rails/wiki/React-Rails,-Coffeescript,-JSX-and-Webpacker

@rmosolgo
Copy link
Member

rmosolgo commented Oct 3, 2017

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViXP @BookOfGreg @rmosolgo