Split RUIProvider into two
#583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/providers/translations/__tests__/TranslationsProvider.test.jsx
Outdated
Show resolved
Hide resolved
bedrich-schindler
approved these changes
Jan 15, 2025
mbohal
force-pushed
the
bc/split-ruiprovider
branch
3 times, most recently
from
f431bc0 to
226a3a0
Compare
adamkudrna
approved these changes
Jan 22, 2025
src/providers/translations/__tests__/TranslationsProvider.test.jsx
Outdated
Show resolved
Hide resolved
This commit splits `RUIProvider` into `TranslationsProvider` and `GlobalPropsProvider`. The reasons fo this change are: * Improve performance by reducing rerenders in cases when the context value change dynamically. * Make code more readable by splitting isolated functionality into isolated prividers.
mbohal
force-pushed
the
bc/split-ruiprovider
branch
from
226a3a0 to
baf0d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits
RUIProviderintoTranslationsProviderandGlobalPropsProvider.The reasons fo this change are:
Improve performance by reducing rerenders in cases when the context value change dynamically.
Make code more readable by splitting isolated functionality into isolated prividers.