Allow check fields and selectable fields to render as required #487 #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
force-pushed
the
bc/487-render-as-required
branch
from
47bcb52 to
0f3b935
Compare
|
I think the feature is good (we need it and we know why), but honestly the docs are very confusing to me. I think we should talk about it before merging - I will schedule this for our Monday meeting. |
I am approving this as it is fine for me. But I might be influenced by the reason for this change. But it is true that one more sentence could be helpful. I am missing the detailed explanation why would user might need this and why it is correct approach. |
bedrich-schindler
approved these changes
Dec 6, 2024
adamkudrna
force-pushed
the
bc/487-render-as-required
branch
from
0f3b935 to
7a65aab
Compare
adamkudrna
commented
Dec 6, 2024
adamkudrna
force-pushed
the
bc/487-render-as-required
branch
from
9c50f7f to
2758996
Compare
mbohal
approved these changes
Jan 23, 2025
atmelmicro
approved these changes
Jan 23, 2025
adamkudrna
force-pushed
the
bc/487-render-as-required
branch
from
2758996 to
0f2698d
Compare
Users may find themselves in a situation where the input is not required (i.e. making the input checked), but they also don't want to render the field as optional because not choosing an option can be perfectly valid. For this case, there is the `renderAsRequired` prop. This affects `CheckboxField`, `Radio`, `SelectField`, and `Toggle`. Closes #487
adamkudrna
force-pushed
the
bc/487-render-as-required
branch
from
0f2698d to
14c5146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may find themselves in a situation where the input is not required (i.e. making the input checked), but they also don't want to render the field as optional because not choosing an option can be perfectly valid. For this case, there is the
renderAsRequiredprop.This affects
CheckboxField,Radio,SelectField, andToggle.Closes #487.