breaking: Drop browser helpers from cli-tools, simplify middleware #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
commented
Jan 29, 2025
| import {launchEditor} from '@react-native-community/cli-tools'; | ||
|
|
||
| type Options = { | ||
| watchFolders: ReadonlyArray<string>; |
There was a problem hiding this comment.
@szymonrybczak Relevant to your other comment, watchFolders is staying around at this level because it ought to (not currently) be used to parse out substitutions from URLs sent by the debugger, e.g. '[metro-project]/path/to/file.js'.
There was a problem hiding this comment.
oh, thanks for explanation!
huntie
force-pushed
the
simplify-open-middleware
branch
from
05076b8 to
76ad4d6
Compare
huntie
commented
Jan 29, 2025
| .use('/open-url', openURLMiddleware) | ||
| .use('/status', statusPageMiddleware) | ||
| // TODO: Remove. Requires standardized JSON body parsing support in Metro. |
There was a problem hiding this comment.
Fun 😄. We have a fix to make around this in Metro. See the original CLI PR: #1147.
I’ve actioned an initial change in React Native — also required for the substitution of body-parser for the endpoints in this PR:
Once removed, we can simplify further and apply .use(json()) against this entire middleware stack.
szymonrybczak
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Completes the removal of pieces related to Remote JS Debugging.
Breaking: The
launchDefaultBrowserandlaunchDebuggerexports ofcli-toolsare removed.Test Plan:
Repeated test plan of #2587.
✅ For a test error in
RNTester, component stack is correctly symbolicated in RedBoxChecklist