Refactor (#7)

README.md

@@ -2,6 +2,12 @@
 
 Flake8 plugin to detect (too) common mistakes and bad practices in Tkinter projects
 
+## Installation
+
+```
+pip install flake8-tkinter
+```
+
 
 ## List of warnings
 
@@ -32,6 +38,15 @@ Calling a function with arguments instead of using a lambda or a partial functio
 + ttk.Button(command=lambda: foo(bar, baz))
 ```
 
+### `TK131`
+Don't assign to `w.grid()` / `w.pack()` / `w.place()`, it's return value is `None`
+
+```diff
+- btn = ttk.Button().grid()
++ btn = ttk.Button()
++ btn.grid()
+```
+
 ### `TK201`
 Don't use `from tkinter import *`
 
@@ -113,7 +128,7 @@ Don't use things like `add="+"`. Use a boolean instead
 ## More planned warnings
 
 - Common mistakes
-  - [ ] Warn when assigning to result of `w.pack()` | `w.grid()` | `w.place()` call (`None`) (**TK131**)
+  - [x] Warn when assigning to result of `w.pack()` | `w.grid()` | `w.place()` call (`None`) (**TK131**)
   - [ ] Warn when using more than one`Tk` instance: child windows must be created from `Toplevel` class (**TK101**)
   - [x] Warn when using more than one `mainloop()` call (**TK102**)
   - [ ] Suggest using `w.after(ms)` instead of `time.sleep(s)` (**TK121**)
@@ -136,7 +151,7 @@ Don't use things like `add="+"`. Use a boolean instead
   - [x] Warn when using `tag_bind` inside a loop, but not storing the Tcl command (can cause memory leaks later) (**TK232**)
 
 - Opinionated suggestions
-  - [ ] Suggest changing things like `root.wm_title()` to `root.title()` (tho I use `wm_` quite often) (**TK305**)
+  - [ ] Suggest changing things like `root.wm_title()` to `root.title()` (tho I use `wm_attributes` quite often, probably that should be an exception) (**TK305**)
   - [ ] Warn when calling `mainloop()` on something other than the root window  (**TK303**)
   - [ ] Suggest using more clear binding sequences, like `<Button-1>` instead of `<1>` and `<Key-a>` instead of `<a>` (**TK301**)
   - [ ] Warn if a parent is not specified (?) (**TK306**)

flake8_tkinter/__init__.py

@@ -1,12 +1,12 @@
 from __future__ import annotations
 
 import ast
+from collections.abc import Generator
 from dataclasses import dataclass
-from typing import Generator
 
 from .visitor import Visitor
 
-__version__ = "0.2.5"
+__version__ = "0.5.0"
 
 
 @dataclass(frozen=True)
@@ -19,5 +19,5 @@ def run(self) -> Generator[tuple[int, int, str, None], None, None]:
         visitor = Visitor()
         visitor.visit(self.tree)
 
-        for line, col, msg in visitor.problems:
-            yield line, col, msg, None
+        for error in visitor.errors:
+            yield error.line, error.col, error.msg, None