Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create, create errors #387

Merged
merged 4 commits into from
Feb 23, 2025
Merged

test: create, create errors #387

merged 4 commits into from
Feb 23, 2025

Conversation

abesto
Copy link
Collaborator

@abesto abesto commented Feb 2, 2025

There are a ton of tests in test_objects.rb in Stunt; might as well land them in smaller chunks. Points of interest:

  • Broke the objects tests up into individual files, one per test method in test_objects.rb. Should make working with them a bit simpler.
  • Added msg to a warn! in task.rs to print the kind of exception the task hit. This has nothing to do with the tests, other than: it made things mildly easier to understand / debug.
  • Added missing create() permission checks

@abesto abesto changed the title test/objects: 10% progress test(objects): 10% progress Feb 3, 2025
@abesto abesto marked this pull request as draft February 3, 2025 18:36
@abesto abesto marked this pull request as ready for review February 3, 2025 18:53
@abesto abesto marked this pull request as draft February 3, 2025 21:22
@abesto abesto marked this pull request as ready for review February 3, 2025 21:29
@rdaum rdaum force-pushed the main branch 3 times, most recently from 1dd0029 to 733b100 Compare February 22, 2025 13:23
@abesto abesto marked this pull request as draft February 22, 2025 21:15
@abesto abesto changed the title test(objects): 10% progress test: create, create errors Feb 23, 2025
@abesto abesto marked this pull request as ready for review February 23, 2025 09:18
@rdaum rdaum merged commit 463c348 into rdaum:main Feb 23, 2025
6 checks passed
@abesto abesto deleted the test/objects branch February 23, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants