DoFn state support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r: @pabloem |
iasoon
force-pushed
the
dofn-state-support
branch
from
ba8f230 to
615e351
Compare
|
LGTM! thanks @iasoon |
pabloem
reviewed
Jun 21, 2022
| T = TypeVar("T") | ||
|
|
||
|
|
||
| class RayFuture(sdk_worker._Future[T]): |
There was a problem hiding this comment.
I guess we need this wrapper object no matter what because Beam / SdkWorker expect this interface right?
There was a problem hiding this comment.
Yes, I think that's right. One thing that's a bit unfortunate about this adapter is that the SdkWorker waits for a series of these futures in sequence, which ray can do natively (with ray.get(list_of_futures)). I'm not sure whether it will actually matter in this case, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the state handler to enable stateful DoFns
closes #12