Cups

[vatsake]

1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?
Should solve #74, #81

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
Nope.

3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)
Currently I modified the existing tests, will add more if needed.

4️⃣ Please include a thorough description of the improvement and reasons why it's useful.
Removes the smalot/cups-ipp dependency.

5️⃣ Thanks for contributing! 🙌

Some side notes.

• Currently there is no attribute filtering when querying for printers.
• Currently you can only send 1 file/text per job. IPP actually allows multiple prints per job.
• I couldn't test against a password protected cups server.

[vatsake]

It isn't the best API at the moment. Could be better.
Custom page print-job example:

use Rawilk\Printing\Api\Cups\Types\Collection;
use Rawilk\Printing\Api\Cups\Types\Member;
use Rawilk\Printing\Api\Cups\Types\Primitive\Integer;
use Rawilk\Printing\Facades\Printing;

Printing::newPrintTask()
    ->printer('http://.../printers/...')
    ->content('hello world', 'text/plain')
    ->option(
        'media-col',
        new Collection([
            'media-size' => new Member(
                new Collection([
                    'x-dimension' => new Member(new Integer(9200)),
                    'y-dimension' => new Member(new Integer(1800)),
                ])
            ),
        ])
    )
    ->orientation('reverse-portrait')
    ->send();

[fkoehl]

Thank you @vatsake, it fixes #74 for me!

@rawilk, will you consider approving this PR?

I'm willing to help to do some commits rebasing/polishing if needed.

[rawilk]

Thanks for contributing this, and sorry I haven't reviewed it until now. I'm going to merge this, however I'll probably modify some of it to match my preferred coding style.

[vatsake]

Of course, I just set the ball rolling :)

[rawilk]

Could you tell me what the Version enum is meant for? I'm not super familiar with CUPS, so I'm not sure what the Version is referring to or means.

[vatsake]

Some Cups versions support different versions of IPP.
For example CUPS 1.0 support only IPP 1.0 and CUPS 2.2 supports earlier versions like 2.0, 1.1.

So the enum helps define which one to use for compatibility with the CUPS server you're communicating with.
https://www.cups.org/doc/spec-ipp.html#:~:text=example.com%3Aport/%22.-,CUPS%20IPP%20Operations,-CUPS%20provides%2017

NB! I'm by no means an expert when it comes to IPP :), I needed some cups functionality.

[rawilk]

Thanks for the info. Since your PR introduced some breaking changes, the functionality won't be available until I publish my new v4.x release I'm working on. The breaking changes are fine in this case, since it gives me an excuse to implement some newer php features and do some refactoring of the package in general that I've been meaning to do.

I did refactor your CUPS implementation a little, however for the most part I think it should function correctly and the way you intended it to. Full disclosure though, I haven't actually tested what I've refactored against a real CUPS server, so I'm not 100% sure it will work as intended.

[vatsake]

I would test some functionality.

Currently none of the Cups requests aren't working because the content type is application/json.
The "withBody" method replaces content-type application/ipp.

laravel-printing/src/Api/Cups/CupsRequestor.php

Lines 39 to 45 in 393e97c

	$client = $this->httpClient()
	->withHeaders($opts->headers)
	->withBody($binary)
	->when(
	filled($username) || filled($password),
	fn (PendingRequest $request) => $request->withBasicAuth($username ?? '', $password ?? ''),
	);

[rawilk]

Ah, I see. I didn't realize it did that. I'll update that to make sure the client is using the correct content type.

At some point I'd like to write some tests to check the requests to cups are working, but I'm not 100% sure on how to fake that data yet.