-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php8.2 - dynamic-properties-deprecated #988
Comments
There are quite a few of these peppered around the codebase where data pushed on to connections. I've forked the latest version to address the issue for my own project and have conformed the code to PSR-12 and started applying PHPStan. Would be happy to contribute when the changes are complete. |
Yes it's polluting my logs a lot. I hope they take you up on your offer! |
Does anyone have any viable alternative? |
to solve all problems with php8.2 use "plesk/ratchetphp": "^1.0" |
When I came to look at this problem again it turned out there were other options to updating this code myself, so I took a different route. If you aren't deeply invested in Ratchet and React, you can migrate to the new amphp which uses the Revolt event loop, and use their websocket library: https://github.com/amphp/websocket |
We're on it! 🚀 I understand the current situation is frustrating and I agree that this is something that should have highest priority. We're currently working out an action plan and a sponsoring concept to make sure that Ratchet receives adequate attention. As much as I'd like to commit to having this done in the next couple of days, I'm sure you'll understand this is going to take a couple of weeks (not months, pinky swear). We're already keeping track of the progress for newer PHP versions in #1003, so I'll close this one for now, but I'm happy to continue the discussion nonetheless! We're still working out the details, but if you're interested in helping with this, please feel free to reach out, plus we also very much appreciate sponsors! ❤️ |
Alternative a hack, use: |
@3kbest Good catch, this is definitely a good temporary solution 👍 It's actually quite obvious when you think about it, but for some reason, I didn't mention it before. Thanks for your input! |
The fix is #1060
Uhoh 🙈 |
Creation of dynamic property React\Socket\Connection::$decor is deprecated in /vendor/cboden/ratchet/src/Ratchet/Server/IoServer.php:86
https://php.watch/versions/8.2/dynamic-properties-deprecated#exempt
The text was updated successfully, but these errors were encountered: