Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved rpi_power_supply + Fixed typo #3267

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Moved rpi_power_supply + Fixed typo #3267

merged 2 commits into from
Nov 23, 2023

Conversation

trejan
Copy link
Contributor

@trejan trejan commented Nov 8, 2023

rpi_power_supply is under power/ not bootloader/

$ ls /proc/device-tree/chosen/power/rpi_power_supply 
/proc/device-tree/chosen/power/rpi_power_supply

I've got a question about rpi_power_supply. The documentation says it is 2 32-bit integers but rpi_power_supply has extra padding? Is this a documentation issue or a firmware issue?

$ od -x --endian=big rpi_power_supply
0000000 0000 2e8a 000f 0000

@aallan
Copy link
Contributor

aallan commented Nov 23, 2023

Ping (perhaps?) @pelwell for comment?

@pelwell
Copy link
Contributor

pelwell commented Nov 23, 2023

Yes, the location is wrong - it belongs in the power section. The first word is the VID, but the second word isn't a PID - it's a Product VDO. Don't ask me what that means.

@pelwell
Copy link
Contributor

pelwell commented Nov 23, 2023

@aallan
Copy link
Contributor

aallan commented Nov 23, 2023

Yes, the location is wrong - it belongs in the power section. The first word is the VID, but the second word isn't a PID - it's a Product VDO. Don't ask me what that means.

Like this? 042aa6f

@aallan aallan merged commit 314530f into raspberrypi:develop Nov 23, 2023
1 check passed
@trejan trejan deleted the patch-2 branch November 23, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants