Fix: Avoid or delay instantiating some internal comment nodes until t…

…hey are needed Should be a tiny performance boost for `child.maybe <--` et al
raquo · Dec 12, 2024 · 84e08fb · 84e08fb
1 parent 7a551c6
commit 84e08fb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/scala/com/raquo/laminar/receivers/ChildOptionReceiver.scala b/src/main/scala/com/raquo/laminar/receivers/ChildOptionReceiver.scala
@@ -9,7 +9,7 @@ import com.raquo.laminar.nodes.{ChildNode, CommentNode}
 object ChildOptionReceiver {
 
   def <--(maybeChildSource: Source[Option[ChildNode.Base]]): DynamicInserter = {
-    val emptyNode = new CommentNode("")
+   lazy val emptyNode = new CommentNode("")
     child <-- maybeChildSource.toObservable.map(_.getOrElse(emptyNode))
   }
 
@@ -20,7 +20,7 @@ object ChildOptionReceiver {
     )(implicit
       renderable: RenderableNode[Component]
     ): DynamicInserter = {
-      val emptyNode = new CommentNode("")
+      lazy val emptyNode = new CommentNode("")
       child <-- {
         maybeChildSource
           .toObservable

diff --git a/src/main/scala/com/raquo/laminar/receivers/LockedChildReceiver.scala b/src/main/scala/com/raquo/laminar/receivers/LockedChildReceiver.scala
@@ -21,7 +21,7 @@ class LockedChildReceiver(
 
   /** If `includeSource` emits true, node will be added. Otherwise, it will be removed. */
   def <--(includeSource: Source[Boolean]): DynamicInserter = {
-    val emptyNode = new CommentNode("")
+    lazy val emptyNode = new CommentNode("")
     child <-- includeSource.toObservable.map(if (_) node else emptyNode)
   }