Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the cost of the center point of the robot and return if it's non-traversable space #99

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

corot
Copy link
Collaborator

@corot corot commented Sep 27, 2024

AB#18500

when there's a small obstacle right in front of the robot and obstacle_approach_distance is significant, the enlarged footprint can engulf the obstacle and so the robot is not considered in collision:

PF_fp_KO.mp4

This cannot happen if we check also the cell at the center of the robot, as it will enter inflated space as soon as we start moving:

PF_fp_OK.mp4

Other algorithms check the fp cost the same way, e.g. Hybrid A*.
In theory this should also provide a small increase in performance, as checking a cell is much faster than the checking the footprint lines

@corot corot requested a review from a team September 27, 2024 20:00
Copy link

@plsang plsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change is reasonable to me

base_local_planner/src/costmap_model.cpp Show resolved Hide resolved
@corot corot requested a review from renan028 September 30, 2024 08:42
@corot corot merged commit 294ee8b into devel Sep 30, 2024
1 check passed
@corot corot deleted the js/footprintCost_check_center_cell branch September 30, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants