Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mask combination method #96

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Add mask combination method #96

merged 5 commits into from
Nov 14, 2024

Conversation

renan028
Copy link
Member

@renan028 renan028 commented Sep 11, 2024

Description

part of: AB#17228

  • Instead of using flag use_maximum_, use the combination method
  • Add a new combination method for static layer: Mask

The idea is to be able to subtract the static layer from the costmap, so that we use only the obstacle layer, without the static obstacles (map). Video below.

subtraction-2024-09-11_18.02.11.mp4

Note that the plugins order matter. In this case, we should use:

plugins:
  - {name: obstacle,        type: "costmap_2d::ObstacleLayer"}
  - {name: static,          type: "costmap_2d::StaticLayer"}

@renan028 renan028 requested review from corot and tomin11 September 11, 2024 09:11
@corot
Copy link
Collaborator

corot commented Sep 30, 2024

@renan028 do we still need this?

@renan028
Copy link
Member Author

renan028 commented Oct 1, 2024

@renan028 do we still need this?

I will change this to Mask and fix because it changes to the whole map.
Changing to draft

@renan028 renan028 marked this pull request as draft October 1, 2024 00:18
@renan028 renan028 self-assigned this Oct 1, 2024
@renan028 renan028 changed the title Add subtraction combination method Add mask combination method Nov 8, 2024
@renan028 renan028 marked this pull request as ready for review November 8, 2024 07:54
@renan028 renan028 merged commit 39ea032 into devel Nov 14, 2024
1 check passed
@renan028 renan028 deleted the rs/subtraction branch November 14, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants