Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CUDA 12.8 in Docker nightlies. #571

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 3, 2025

This adds CUDA 12.8 Docker images to the nightly selector.

Depends on rapidsai/docker#728.

@bdice bdice requested a review from a team as a code owner February 3, 2025 13:47
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 7, 2025 8:40pm

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ebb5c5c
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/67a66f8eeafbc70008947796
😎 Deploy Preview https://deploy-preview-571--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdice
Copy link
Contributor Author

bdice commented Feb 7, 2025

There is a bug when selecting Nightly + Docker. I need it to change to a supported CUDA version. I will fix that.

@bdice
Copy link
Contributor Author

bdice commented Feb 7, 2025

Things should be working now. Ready for review.

@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Generally this looks good

Did notice one thing that I had a question on. Is CUDA 12.5 meant to be grayed out here?

Screenshot 2025-02-07 at 5 08 53 PM

Also guessing there will be some follow up work when stable becomes RAPIDS 25.02 and RAPIDS 25.04 is nightly

@bdice
Copy link
Contributor Author

bdice commented Feb 8, 2025

Is CUDA 12.5 meant to be grayed out here?

Yes. See rapidsai/docker#728 and #573.

@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Knew we were deprecating these in 25.04 with PR: #573

However was unaware they would be grayed out for 25.02 where they are still supported

@bdice
Copy link
Contributor Author

bdice commented Feb 11, 2025

Knew we were deprecating these in 25.04 with PR: #573
However was unaware they would be grayed out for 25.02 where they are still supported

@jakirkham The RSN is a little ambiguous. We will not ship CUDA 12.5 Docker images in 25.02. The "deprecation notice" is really just a removal/replacement with 12.8. The RSN reads:

RAPIDS is planning to deprecate support of CUDA 12.5 Docker containers in Release v25.02, and to cease publishing CUDA 12.5 Docker containers before the v25.02 release. The CUDA 12.5 containers will be replaced by CUDA 12.8 containers. We are continuing support for CUDA 11.8 and 12.0 containers.

@jakirkham
Copy link
Member

jakirkham commented Feb 11, 2025

Oh that was non-obvious. Thank you for clarifying! 🙏

Would suggest we title that differently to make it more clear they are going away soon: #573 (comment)

@bdice
Copy link
Contributor Author

bdice commented Feb 11, 2025

@jakirkham Can we approve this and let the RSN discussion be handled separately?

@jakirkham jakirkham merged commit 051064e into rapidsai:main Feb 11, 2025
6 checks passed
@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants