Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.8.0 #621

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 28, 2025

This PR uses CUDA 12.8.0 to build and test.

xref: rapidsai/build-planning#139

@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jan 28, 2025
Copy link

copy-pr-bot bot commented Jan 28, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice bdice marked this pull request as ready for review January 28, 2025 15:57
@bdice bdice requested review from a team as code owners January 28, 2025 15:57
@bdice bdice requested review from jameslamb and KyleFromNVIDIA and removed request for jameslamb January 28, 2025 15:57
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

wheel-build-cuvs on CUDA 11 was failing like this:

ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
    nvidia-cusparse-cu11 from https://pypi.nvidia.com/nvidia-cusparse-cu11/nvidia_cusparse_cu11-11.7.5.86-py3-none-manylinux2014_aarch64.whl#sha256=6c7da46abee7567e619d4aa2e90a1b032cfcbd1211d429853b1a6e87514a14b2 (from libcuvs-cu11==25.2.*,>=0.0.0a0):
        Expected sha256 6c7da46abee7567e619d4aa2e90a1b032cfcbd1211d429853b1a6e87514a14b2
              Got        351199bf8c461105dce5b92d15e4ace02ddd70fa9dea22ab02f28ea31c589517

(build link)

That's a known problem being worked on elsewhere (like rapidsai/gha-tools#132), and it's usually resolved by a re-run.

Re-triggered CI here. All the CI that did run looked good though!

@jameslamb jameslamb removed the request for review from KyleFromNVIDIA January 28, 2025 22:50
@vyasr vyasr requested a review from a team as a code owner January 29, 2025 22:48
@vyasr
Copy link
Contributor

vyasr commented Jan 30, 2025

/merge

@rapids-bot rapids-bot bot merged commit 9489d0c into rapidsai:branch-25.02 Jan 30, 2025
62 checks passed
rapids-bot bot pushed a commit that referenced this pull request Feb 4, 2025
This cleans up one change from #621 that could not be reverted in #630. It is now safe to use `ci-imgs`' `latest` tag, because rapidsai/ci-imgs#236 is merged.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mike Sarahan (https://github.com/msarahan)

URL: #643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

5 participants