Feature/brands #85
Merged
Feature/brands #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BobWez98
commented
Oct 31, 2024
BobWez98
commented
- Refactored the brands import
- Allow a Hybrid runway collection to have a route
- Structured blueprints of runway resources
- Removed old import buttons
royduin
requested changes
Oct 31, 2024
BobWez98
commented
Nov 5, 2024
| @@ -37,7 +37,7 @@ | |||
| "statamic-rad-pack/runway": "^7.11", | |||
| "statamic/cms": "^5.0", | |||
| "statamic/eloquent-driver": "^4.9", | |||
| "tdwesten/statamic-builder": "^1.0", | |||
| "tdwesten/statamic-builder": "dev-main", | |||
There was a problem hiding this comment.
Put it on dev-main for now, there's no release yet but i added tdwesten/statamic-builder#37
kevinmeijer97
approved these changes
Nov 5, 2024
indykoning
reviewed
Nov 15, 2024
There was a problem hiding this comment.
I suggest flipping this function around for readability.
Could you add a comment to the function on why we cannot do the entry query when running in console
|
I think this can be merged @royduin @kevinmeijer97 . I removed the UPGRADING.md again because @kevinmeijer97 added this in the docs. |
royduin
reviewed
Jan 23, 2025
| @@ -32,14 +32,14 @@ | |||
| "require": { | |||
| "php": "^8.1|^8.2", | |||
| "justbetter/statamic-glide-directive": "^2.1", | |||
| "rapidez/blade-directives": "^1.0", | |||
| "rapidez/blade-directives": "^0.6", | |||
|
Merged, but the composer dependency versions should still be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.