Add test and improve performance #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
May 1, 2020
package.json
Outdated
| "standard": "^11.0.1" | ||
| "budo": "^11.6.3", | ||
| "puppeteer": "^3.0.2", | ||
| "random-access-test": "github:random-access-storage/random-access-test", |
There was a problem hiding this comment.
i didn't realise we had this! should we publish that to npm?
There was a problem hiding this comment.
I noticed the same. We should, I think is really helpful to test these modules.
|
These changes looks great @tinchoz49. Anything I can do to move this forward? |
|
Hey @arj03 thanks :). We are testing this PR in our application and trying to get stability. It seems working but we are having a race condition issue and we need to check if it belongs to this PR or not. After that I will put into review next week. |
|
Been testing this, not sure about the speed diff, but at least I didn't get any errors from manual testing with this new code. |
tinchoz49
force-pushed
the
tinchoz49/improve-performance
branch
from
0bd3705 to
816729f
Compare
tinchoz49
force-pushed
the
tinchoz49/improve-performance
branch
from
816729f to
7c73c6f
Compare
|
On further testing I'm getting a few of these: Could not satisfy length |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently support for chrome 81 decrease the performance since we have to get on every read/write an updated
entry.file: #3This PR improve that:
The
writeprocess only use thesizeprop of the file, something that we can get updated on every write request and just use that information instead of getting a new entry file.The
readprocess is different, it needs the updated file, so every time that we write into the file wemarked to update. With this approach only when the file was really updated it would try to get a new entry file.current version
PR version