Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to pass groups with transactions not to be signed? #50

Open
ivnsch opened this issue Nov 21, 2021 · 7 comments
Open

Is it possible to pass groups with transactions not to be signed? #50

ivnsch opened this issue Nov 21, 2021 · 7 comments

Comments

@ivnsch
Copy link

ivnsch commented Nov 21, 2021

WalletConnect allows to pass group transactions that are not to be signed by the current user (i.e. only for informative purpose). See e.g tutorial:

const txnsToSign = txns.map(txn => {
  const encodedTxn = Buffer.from(algosdk.encodeUnsignedTransaction(txn.txn)).toString("base64");

  return {
    txn: encodedTxn,
    message: 'Description of transaction being signed',
    // Note: if the transaction does not need to be signed (because it's part of an atomic group
    // that will be signed by another party), specify an empty singers array like so:
    // signers: [],
  };
});

This way it's possible for the user to review all the transactions in the group when signing their part.

Is this possible with My Algo?

@Alex99y
Copy link
Contributor

Alex99y commented Nov 22, 2021

Hello @ivanschuetz ! No, it isn't possible. MyAlgo Connect only receives the transactions that the user could sign.

@ivnsch
Copy link
Author

ivnsch commented Nov 23, 2021

Okay, I'd like to request this feature. At least for some groups it seems critical, e.g. for an atomic swap, it would make sense to be able to review the tokens you receive before you sign the "send" transaction.

@Alex99y
Copy link
Contributor

Alex99y commented Nov 23, 2021

@ivanschuetz yes, we are aware of that, but it is really difficult to make this feature with the current implementation. Our long-term plan is to implement ARC-0001 which will easily allow this feature.
https://github.com/algorandfoundation/ARCs/blob/main/ARCs/arc-0001.md

@gidonkatten
Copy link

+1 for this feature

@ismael-elatifi
Copy link

ismael-elatifi commented Apr 9, 2022

Yes this feature is very much wanted !
AlgoSigner already supports this :

let signedTxs = await AlgoSigner.signTxn([
  {
    txn: base64Txs[0],
  },
  {
    // This tells AlgoSigner that this transaction is not meant to be signed
    txn: base64Txs[1],
    signers: [],
  },
]);

https://github.com/PureStake/algosigner/blob/develop/docs/dApp-integration.md#atomic-transactions

@webbgeorge
Copy link

Hi there! Are there any current plans for this feature to be implemented? @Alex99y does MyAlgo have a public roadmap you can share?

@nkbt
Copy link

nkbt commented May 5, 2022

@webbgeorge

Hi there! Are there any current plans for this feature to be implemented? @Alex99y does MyAlgo have a public roadmap you can share?

You can just pass only unsigned txns from the group, no need to send pre-signed ones. MyAlgo is ok and does not strictly check for group validity (like AlgoSIgner does)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants