-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to pass groups with transactions not to be signed? #50
Comments
Hello @ivanschuetz ! No, it isn't possible. MyAlgo Connect only receives the transactions that the user could sign. |
Okay, I'd like to request this feature. At least for some groups it seems critical, e.g. for an atomic swap, it would make sense to be able to review the tokens you receive before you sign the "send" transaction. |
@ivanschuetz yes, we are aware of that, but it is really difficult to make this feature with the current implementation. Our long-term plan is to implement ARC-0001 which will easily allow this feature. |
+1 for this feature |
Yes this feature is very much wanted ! let signedTxs = await AlgoSigner.signTxn([
{
txn: base64Txs[0],
},
{
// This tells AlgoSigner that this transaction is not meant to be signed
txn: base64Txs[1],
signers: [],
},
]); https://github.com/PureStake/algosigner/blob/develop/docs/dApp-integration.md#atomic-transactions |
Hi there! Are there any current plans for this feature to be implemented? @Alex99y does MyAlgo have a public roadmap you can share? |
You can just pass only unsigned txns from the group, no need to send pre-signed ones. MyAlgo is ok and does not strictly check for group validity (like AlgoSIgner does) |
WalletConnect allows to pass group transactions that are not to be signed by the current user (i.e. only for informative purpose). See e.g tutorial:
This way it's possible for the user to review all the transactions in the group when signing their part.
Is this possible with My Algo?
The text was updated successfully, but these errors were encountered: