Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to exporter image, drone CI #8

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

HarrisonWAffel
Copy link
Contributor

@HarrisonWAffel HarrisonWAffel commented Feb 23, 2024

Relates to: rancher/windows#223

  • Removes slack integration steps from drone.yaml, from what I can tell this integration isn't used anymore
  • Updates CI scripts
    • use ltsc2019 tags to be inline with how windows images are tagged throughout rancher
      • It should be noted that both 1809 and ltsc2019 tags have the exact same contents
    • remove hyper-v isolation build condition, as all official builds will come from CI, which ensures that the host id and release ID windows versions will always match
  • Update the docker file
    • Removes invalid empty separators resolving several docker build warnings
    • Removed the use of entry.ps1, as the exporter dependency on wins is being removed. The entry point is now just invoking the downloaded binary directly with the same arguments passed by the rancher-monitoring chart
    • Updated the nanoserver stage as we no longer need to run powershell scripts, from my testing I can see that this reduces final image size by ~100MB
  • When building the image in environments the version cannot be detected, automatically set the version to dev

Changing the Dockerfile to no longer invoke wins would be considered a breaking change when using this image in rancher monitoring (as the chart needs to also be changed), so we should cut a new release of this in the v0.1.x line

@HarrisonWAffel HarrisonWAffel force-pushed the image-improvements branch 7 times, most recently from f878b46 to 2eb2a5f Compare February 27, 2024 20:05
@HarrisonWAffel HarrisonWAffel force-pushed the image-improvements branch 2 times, most recently from 993c1c4 to 2d31084 Compare February 27, 2024 20:45
Copy link
Contributor

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when this is merged, it should be cut as a v0.1.0 since this version of our image will definitely not work with rancher/wins.

@HarrisonWAffel HarrisonWAffel merged commit c2a69b6 into rancher:master Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants