-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to exporter image, drone CI #8
Merged
HarrisonWAffel
merged 3 commits into
rancher:master
from
HarrisonWAffel:image-improvements
Mar 7, 2024
Merged
Improvements to exporter image, drone CI #8
HarrisonWAffel
merged 3 commits into
rancher:master
from
HarrisonWAffel:image-improvements
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e72fb68
to
fb768a5
Compare
f878b46
to
2eb2a5f
Compare
993c1c4
to
2d31084
Compare
aiyengar2
reviewed
Feb 27, 2024
aiyengar2
reviewed
Feb 27, 2024
aiyengar2
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when this is merged, it should be cut as a v0.1.0 since this version of our image will definitely not work with rancher/wins
.
2d31084
to
1c5f358
Compare
aiyengar2
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: rancher/windows#223
ltsc2019
tags to be inline with how windows images are tagged throughout rancher1809
andltsc2019
tags have the exact same contentsentry.ps1
, as the exporter dependency on wins is being removed. The entry point is now just invoking the downloaded binary directly with the same arguments passed by the rancher-monitoring chartnanoserver
stage as we no longer need to run powershell scripts, from my testing I can see that this reduces final image size by ~100MBdev
Changing the Dockerfile to no longer invoke wins would be considered a breaking change when using this image in rancher monitoring (as the chart needs to also be changed), so we should cut a new release of this in the
v0.1.x
line