Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring V2] windows-exporter should no longer depend on rancher/wins #223

Closed
aiyengar2 opened this issue Dec 12, 2023 · 5 comments
Closed
Assignees
Milestone

Comments

@aiyengar2
Copy link

Currently, Monitoring V2 for Windows has a dependency on the underlying distribution using rancher/wins and supporting the ability to mount the established wins named pipes to execute host-process operations on the host.

https://github.com/rancher/charts/blob/8a4cd82fddc632d059d587a47aa7dd318e0781b7/charts/rancher-windows-exporter/100.0.0/templates/daemonset.yaml#L31-L49

This dependency should be removed to allow Monitoring V2 to be installed onto non-RKE2 clusters.

@aiyengar2 aiyengar2 changed the title windows-exporter should no longer depend on rancher/wins [Monitoring V2] windows-exporter should no longer depend on rancher/wins Dec 12, 2023
Copy link

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@HarrisonWAffel
Copy link
Contributor

This issue can now be tested as the charts PR for 2.8 has been merged. Version 103.1.0-rc1+up45.31.1 should be used to test this issue. Basic functionality testing for monitoring windows nodes as well as chart upgrade and downgrade paths should be tested.

Testing of the related changes for 2.9 will be tracked in #234

@slickwarren
Copy link
Contributor

did some testing; currently blocked due to an issue with exporter not liking the fact that wins is on an RC'd version. Harrison is aware of this issue and will push a fix once the proxy testing is done

@HarrisonWAffel
Copy link
Contributor

rancher-wins has been bumped in v2.8, this is no longer blocked

@slickwarren
Copy link
Contributor

tested on v2.8-head (421ce19)

  • deploy a windows cluster on 1.27 using the currently released chart
    • upgrade the chart to 103.1.0-rc1+up45.31.1 -- pass
  • deploy a windows cluster on the latest k8s version available (1.28)
    • install the chart 103.1.0-rc1+up45.31.1 -- pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants