Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rancher/mirrored-prometheus-windows-exporter 0.25.1 #592

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

HarrisonWAffel
Copy link
Contributor

Pull Request Checklist

  • Change does not remove any existing Images or Tags in the images-list file
  • Change does not remove / overwrite exiting Images or Tags in Rancher DockerHub
  • If updating an existing entry, verify the SOURCE is still accurate and upstream hasn't been migrated to a new regitry or repo (if they've migrated, a new repo request to EIO is needed to comply with the SOURCE DESTINATION TAG pattern)
  • New entries are in format SOURCE DESTINATION TAG
  • New entries are added to the correct section of the list (sorted lexicographically)
  • New entries have a repo created in Rancher Dockerhub (where the image will be mirrored to)
  • New entries are licensed with Rancher favored licenses - Apache 2 and MIT - or approved licenses - as according to CNCF approved licenses.
  • New entries, when used in Rancher or Rancher's provided charts, have their corresponding origin added in Rancher's images origins file (must be added for all Rancher versions >= v2.7).
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

New Image

Linked Issues

rancher/windows#234

Additional Notes

Final Checks after the PR is merged

  • Confirm that you can pull the new images and tags from DockerHub

@HarrisonWAffel HarrisonWAffel requested a review from a team as a code owner March 12, 2024 15:20
@brandond
Copy link
Member

time="2024-03-12T15:21:44Z" level=fatal msg="Error parsing manifest for image: choosing image instance: no image found in manifest list for architecture amd64, variant \"\", OS linux"
ERROR: Image ghcr.io/prometheus-community/windows-exporter:0.25.1 does not exist

This is going to be a problem... the checks require that the source be available for amd64/linux. You'll need to fix the mirror scripts first.

@HarrisonWAffel HarrisonWAffel force-pushed the upstream-windows-exporter branch from 4b7a488 to 983914d Compare April 8, 2024 21:48
@brandond brandond merged commit 2452f01 into rancher:master Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants