Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CAPI support to 1.9 #525

Open
1 task done
Danil-Grigorev opened this issue Dec 17, 2024 · 3 comments
Open
1 task done

Update CAPI support to 1.9 #525

Danil-Grigorev opened this issue Dec 17, 2024 · 3 comments
Assignees
@Danil-Grigorev
Labels
area/api Indicates an issue or PR relates to the APIs area/dependency Issues or PRs related to dependency changes

Comments

@Danil-Grigorev
Copy link
Contributor

Danil-Grigorev commented Dec 17, 2024 •
edited
Loading

This is an epic for 1.9 update, and changes required to facilitate that.
@Danil-Grigorev Danil-Grigorev added area/api Indicates an issue or PR relates to the APIs area/dependency Issues or PRs related to dependency changes labels Dec 17, 2024
@Danil-Grigorev Danil-Grigorev mentioned this issue Dec 17, 2024
Merged
4 tasks
@Danil-Grigorev
Copy link
Contributor Author

Issues can be reproduced on #526 which only updates CAPI to 1.9 without changing the code. It appears kubernetes-sigs/cluster-api#11457 has a check which resolves the problem, but it applies only for kubeadm CP provider.

@Danil-Grigorev
Copy link
Contributor Author

After some investigation opened kubernetes-sigs/cluster-api#11591 and a fix kubernetes-sigs/cluster-api#11590 which unblocked machine deletion after update

@Danil-Grigorev Danil-Grigorev moved this from CAPI Backlog to In Progress (8 max) in CAPI & Hosted Kubernetes providers (EKS/AKS/GKE) Dec 18, 2024
@Danil-Grigorev Danil-Grigorev self-assigned this Dec 18, 2024
@Danil-Grigorev Danil-Grigorev moved this from In Progress (8 max) to Blocked in CAPI & Hosted Kubernetes providers (EKS/AKS/GKE) Dec 18, 2024
@Danil-Grigorev
Copy link
Contributor Author

From the discussion it seems there is https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md#machine-newconditions proposes removal of existing conditions in the future, which acts as a way to ensure draining success and volume detachment success does terminate further attempts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danil-Grigorev Danil-Grigorev

Labels
area/api Indicates an issue or PR relates to the APIs area/dependency Issues or PRs related to dependency changes
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Danil-Grigorev