Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent addition of illegal characters to new/renamed UUIDs #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gordlin
Copy link
Member

@gordlin gordlin commented Feb 21, 2025

Related Item(s)

Issue #550

Changes

  • [FIX] Adds new checks when entering a new UUID (or renaming an existing UUID) to prevent adding reserved URL characters (: / # ? & @ % +)
  • [FIX] Makes various minor styling changes to UUID errors.

Testing

Steps:

  1. Go to the Create New Storylines Product page.
  2. Try entering any reserved URL character (: / # ? & @ % +). You should get an error, and should not be able to continue to the editor without removing it.
  3. Go to the Load Existing Storylines Product page. Enter an existing UUID and load.
  4. Click Click here to change UUID. Try entering any reserved URL character (: / # ? & @ % +). You should get an error, and should not be able to rename until you remove it.

This change is Reviewable

@gordlin gordlin added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Feb 21, 2025
Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/uuid-illegal-chars

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like when I enter a special character in the UUID field when creating a new product or renaming a product, page is blank and results in the following console error:

image.png

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Member Author

@gordlin gordlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donethanks, I think. Looks like we need to escape special characters in vue-i18n.

Let me know if there are still any issues on your end.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants