Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter options to timeslider #533

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

spencerwahl
Copy link
Member

@spencerwahl spencerwahl commented Jan 9, 2025

Related Item(s)

https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/121

Changes

  • [FEATURE] Adds two formatter modes to the timeslider, values and ranges
    • values uses the slider value as an index for the array of labels
    • ranges is similar but allows concatenation of ranges in the label above the slider, it also requires a 2d array

Notes

ranges
image

values
image

No formatter
image

Testing

Steps:

  1. Go to map with timeslider
  2. See fancy labeling

NOTE: I had to change the values for the slider for this test, nothing will show on the map for the affected layer. I will undo the config change before merge


This change is Reviewable

Copy link
Member Author

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion


public/00000000-0000-0000-0000-000000000000/00000000-0000-0000-0000-000000000000_en.json line 501 at r1 (raw file):

                        "formatters": {
                            "mode": "ranges",
                            "ranges": [["March", "May"], ["June", "August"], ["Sept", "Nov"], ["Dec", "Feb"]]

BLOCK, do not merge until removed

Copy link

github-actions bot commented Jan 9, 2025

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA)

@spencerwahl spencerwahl merged commit d8462a7 into ramp4-pcar4:main Jan 14, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants