Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework panel ordering to allow multimedia on the left panel #416

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Mar 22, 2024

Related Item(s)

ramp4-pcar4/storylines-editor#252, ramp4-pcar4/storylines-editor#274

Changes

  • Previously, we would always put the text panel on the left and sticky the right panel if it was multimedia. Logic has now been modified to respect config ordering.
  • On mobile, the multimedia panel will be prioritized first over a text panel. For all of the ordering rules see the comment in the PR.

Testing

Steps:

  1. Open the demo page and ensure that the Default RAMP4 Sample slide is swapped correctly. The map should be on the left and the text should be on the right. In mobile view, the map should be stuck to the top.
  2. The Pollution in your neighbourhood slide has two text panels next to each other. Ensure that these are still displaying in the correct order.
  3. Play around with the app in mobile mode and ensure things are working as expected.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-252/#/en/00000000-0000-0000-0000-000000000000

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@KashishMistry KashishMistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit 259a0b6 into ramp4-pcar4:main Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants