fix logo not displaying when configFileStructure is provided #399
Conversation
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-245/#/en/00000000-0000-0000-0000-000000000000 |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
Related ramp4-pcar4/storylines-editor#245
This PR fixes an issue where the logo isn't appearing when you enter preview mode in the Storylines editor. Because it is not guaranteed that images are uploaded to the server when in preview mode, we use
URL.createObjectURL()to create a temporarily accessible path to the image. It seems like the temporary image source was being overwritten somehow (possibly due to the forceUpdate?) when opening the preview which is why the image was not appearing.The issue should now be fixed, but since this PR is in the main repo and not the editor we won't be able to test it through the demo link.
Note: the code added to
vue.config.jsin this PR just fixes an issue with building locally.This change is