Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

http status code cannot be outside of range 100-599 #351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

http status code cannot be outside of range 100-599 #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion raml-parser-2/src/main/java/org/raml/v2/internal/impl/commons/grammar/BaseRamlGrammar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,6 @@ protected Rule protocols()

protected Rule responseCodes()
{
return range(Range.closed(100L, 599L));
return range(Range.closed(0L, 999L));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open a spec bug to clarify what should be the allowed range of status codes, otherwise next time somebody will want to use status code 1050 and it will not be possible.

}
}
7 changes: 7 additions & 0 deletions raml-parser-2/src/test/resources/org/raml/v2/parser/custom-http-status-codes/input.raml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#%RAML 1.0
title: My API
/resource:
get:
responses:
0:
999:
34 changes: 34 additions & 0 deletions raml-parser-2/src/test/resources/org/raml/v2/parser/custom-http-status-codes/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
RamlDocumentNode (Start: 11 , End: 78, On: input.raml, Source: SYObjectNode)
KeyValueNodeImpl (Start: 11 , End: 24, On: input.raml)
SYStringNode: "title" (Start: 11 , End: 16, On: input.raml)
OverlayableObjectNodeImpl (Start: 18 , End: 24, On: input.raml, Source: SYStringNode)
KeyValueNodeImpl (Start: 11 , End: 24, On: input.raml)
StringNodeImpl: "value" (Start: -1 , End: -1)
OverlayableStringNode: "My API" (Start: 18 , End: 24, On: input.raml)
ResourceNode (Start: 25 , End: 78, On: input.raml, Source: KeyValueNodeImpl)
SYStringNode: "/resource" (Start: 25 , End: 34, On: input.raml)
SYObjectNode (Start: 38 , End: 78, On: input.raml)
MethodNode (Start: 38 , End: 78, On: input.raml, Source: KeyValueNodeImpl)
SYStringNode: "get" (Start: 38 , End: 41, On: input.raml)
SYObjectNode (Start: 47 , End: 78, On: input.raml)
KeyValueNodeImpl (Start: 47 , End: 78, On: input.raml)
SYStringNode: "responses" (Start: 47 , End: 56, On: input.raml)
SYObjectNode (Start: 64 , End: 78, On: input.raml)
ResponseNode (Start: 64 , End: 66, On: input.raml, Source: KeyValueNodeImpl)
SYIntegerNode: 0 (Start: 64 , End: 65, On: input.raml)
SYNullNode (Start: 66 , End: 66, On: input.raml)
ResponseNode (Start: 73 , End: 77, On: input.raml, Source: KeyValueNodeImpl)
SYIntegerNode: 999 (Start: 73 , End: 76, On: input.raml)
SYNullNode (Start: 77 , End: 77, On: input.raml)
KeyValueNodeImpl (Start: -1 , End: -1)
StringNodeImpl: "displayName" (Start: -1 , End: -1)
ObjectNodeImpl (Start: -1 , End: -1)
KeyValueNodeImpl (Start: -1 , End: -1)
StringNodeImpl: "value" (Start: -1 , End: -1)
OverlayableStringNode: "get" (Start: -1 , End: -1, Source: SYStringNode)
KeyValueNodeImpl (Start: -1 , End: -1)
StringNodeImpl: "displayName" (Start: -1 , End: -1)
ObjectNodeImpl (Start: -1 , End: -1)
KeyValueNodeImpl (Start: -1 , End: -1)
StringNodeImpl: "value" (Start: -1 , End: -1)
OverlayableStringNode: "/resource" (Start: -1 , End: -1, Source: SYStringNode)