Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dApp switch banner appearing on non-injectable pages #1713

Merged
merged 4 commits into from
Oct 2, 2024
Merged

fix: dApp switch banner appearing on non-injectable pages #1713

merged 4 commits into from
Oct 2, 2024

Conversation

DanielSinclair
Copy link
Collaborator

Fixes BX-1569
Figma link (if any):

What changed (plus any additional context for devs)

  • detecting if injection failed before throwing switch account nudges (sheet or banner)
  • added fallback dApp dApp name

Screen recordings / screenshots

  • No longer appearing on chrome:// URLs
Screenshot 2024-09-24 at 12 19 53 AM

What to test

  • dApp account switch banner appears when expected on connected dApps

@linear Linear
Copy link

linear bot commented Sep 24, 2024

BX-1569 Skip dApp Wallet Switch banner nudges on no-injection pages

@DanielSinclair DanielSinclair changed the title @daniel/fix invalid nudge fix: dApp switch banner appearing on non-injectable pages Sep 24, 2024
@DanielSinclair DanielSinclair merged commit 6a4d0b6 into master Oct 2, 2024
13 of 14 checks passed
@DanielSinclair DanielSinclair deleted the @daniel/fix-invalid-nudge branch October 2, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@derHowie derHowie derHowie approved these changes

@BrodyHughes BrodyHughes Awaiting requested review from BrodyHughes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielSinclair @estebanmino @derHowie