Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (particularly ugly) fix for #464 based on #464 (comment) and #464 (comment). It allows
DimUnitRange
to be mixed withInteger
and/orBase.OneTo
axes, so long as aDimUnitRange
appears within the first 4 axes, which should cover the most common cases. Fixes #464@mcabbot I ended up dispatching also on
Integer
types for axes because otherwise we need to also implement overloads to hitsimilar(::AbstractArray, ::Tuple)
for all of these combinations, which seemed unnecessary.Still need to exhaustively test, but now this works: