This repository has been archived by the owner on Apr 12, 2020. It is now read-only.
Massive Update #19
Open
Massive Update #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this get merged. Much needed. Could not get the current version to work. |
MalPr0
reviewed
Apr 1, 2018
| injectTapEventPlugin(); | ||
|
|
||
| render( | ||
| <Router routes={routes} history={browserHistory} />, document.getElementById('app') | ||
| <BrowserRouter> |
There was a problem hiding this comment.
Move login out app
`
<BrowserRouter>
<div>
<Switch>
<Route exact path="/login" component={LoginPage}/>
<MuiThemeProvider muiTheme={ThemeDefault}>
<App />
</MuiThemeProvider>
</Switch>
</div>
</BrowserRouter>
`
|
@rafaelhz would you merge this? |
|
@xeoncross how can I use your PR? |
|
@Markkos89 just checkout https://github.com/Xeoncross/react-material-admin-template instead of this repo. However, it's been a couple years so there will probably be some additional changes needed. Nice thing is that react-router-dom is still v4. |
|
Sorry guys, this repo is really outdated, you can clone the @xeoncross version, or use a free theme from material-ui: https://material-ui.com/store/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current react-material-admin-template repo does not work with the current NPM (and lib) versions. This was a refresh porting all the
srccomponents into a brand newcreate-react-appcheckout and then addingaxios(ajax) andfacebook(login) demos.Unit tests, linting, etc, are all gone. I broke them all. I couldn't get any of it to work so it was removed. Needs to be fixed and added back in.
This pull request works, adds some new features:
Broke/Removed others: