-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add help window feature when ? is pressed #70
[feature] add help window feature when ? is pressed #70
Conversation
Hi, great job at adding the help window! I have one suggestion, I think it should only be accessible Normal mode, so either during Pause, or before running the test. Guess the description wasn't clear enough, sorry about that. |
Hey @radlinskii, I just addressed that in the last 2 commits. Nice project btw. |
Just did |
the |
ref #70 |
I'll fix it. I've seen the issue. |
Hi @radlinskii I've addressed the issue. Was having a hectic week at work, hence the delay.
|
did you even try to run the app with your changes? There is a runtime error when running the app on your branch, that is kind of hard to miss... Before you've asked for approval even before the app would compile so I'm assuming you still didn't try to run it, which is kind of disturbing to me. |
when help window is rendered then 's' keypress should not start test, or if it did, than the help window should hide. |
Okay, the most user-friendly one is the econd option -- to automatically hide help when 's' is pressed. The user can now:
Any other changes required to improve the user experience? |
No description provided.