radio-group: Add unstable ItemRoot and ItemTrigger
#3519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 69c0e29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chaance
changed the title
ItemRoot, ItemTrigger and `ItemBubbleIn…ItemRoot, ItemTrigger and ItemBubbleInput
chaance
force-pushed
the
chance/bubble-input-splits-radio
branch
3 times, most recently
from
823ff29 to
621eb54
Compare
chaance
changed the title
ItemRoot, ItemTrigger and ItemBubbleInputItemRoot and ItemTrigger
chaance
force-pushed
the
chance/bubble-input-splits-radio
branch
from
f50b9fe to
69c0e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of goals set by #3459, this PR breaks the Radio Group's
Itemcomponent into separate parts:ItemRootItemTriggerThis will ultimately allow users to have more control over the behavior of radio items in a nested form context, and prevent rendering the bubble input altogether if needed.
I intentionally am not exposing the
ItemBubbleInputat this time. I think the current behavior is a bit wonky and inconsistent with how a native checkbox group events work. We should flesh this out a bit better and update the API as needed before the next major release.